Re: [PATCH] symbolic-ref: trivial style fix

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 15, 2013, 23:16 UTC
Message-ID: <20131015231628.GG9464@google.com>
In-Reply-To: <xmqq4n8ich89.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> From: Felipe Contreras <felipe.contreras@gmail.com>
> Subject: C: have space around && and || operators

[...]

Show 6 quoted lines

>  builtin/read-tree.c    | 2 +-
>  builtin/rev-list.c     | 2 +-
>  builtin/symbolic-ref.c | 2 +-
>  compat/regex/regcomp.c | 2 +-
>  xdiff/xemit.c          | 2 +-
>  5 files changed, 5 insertions(+), 5 deletions(-)

For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

[...]

Show 8 quoted lines

> --- a/compat/regex/regcomp.c
> +++ b/compat/regex/regcomp.c
> @@ -339,7 +339,7 @@ re_compile_fastmap_iter (regex_t *bufp, const re_dfastate_t *init_state,
>  	      p = buf;
>  	      *p++ = dfa->nodes[node].opr.c;
>  	      while (++node < dfa->nodes_len
> -		     &&	dfa->nodes[node].type == CHARACTER
> +		     && dfa->nodes[node].type == CHARACTER

It took a little staring to see what changed here. The preimage has a tab, probably from an autoformatter gone wild. I don't think fixing it should interfere with importing new versions of compat/regex, so the change seems fine.

Thanks, Jonathan