Re: [PATCH 0/2] remote-helpers: graduate
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 21, 2014, 18:06 UTC
- Message-ID
- <xmqqbnvua768.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <1398029971-1396-1-git-send-email-felipe.contreras@gmail.com>
Felipe Contreras <felipe.contreras@gmail.com> writes:
> There doesn't seem to be any reason to keep these remote-helpers in the contrib > area.
Yay.
I wouldn't phrase it "doesn't seem to be any reason", though. The decision to include is not done due to lack of negatives, but because adding them would be useful.
And I think for these two, it holds true---people seem to have been experimenting with them and getting good results with occasional bug reports that are addressed in a reasonable promptness.
Will queue.
Show 22 quoted lines
> Felipe Contreras (2): > remote-helpers: move out of contrib > remote-helpers: move tests out of contrib > > .gitignore | 2 ++ > Makefile | 2 ++ > contrib/remote-helpers/Makefile | 14 -------------- > contrib/remote-helpers/git-remote-bzr => git-remote-bzr.py | 0 > contrib/remote-helpers/git-remote-hg => git-remote-hg.py | 0 > t/Makefile | 8 +++++++- > .../remote-helpers/test-bzr.sh => t/remote-helpers/bzr.t | 4 ++-- > .../test-hg-bidi.sh => t/remote-helpers/hg-bidi.t | 4 ++-- > .../test-hg-hg-git.sh => t/remote-helpers/hg-hg-git.t | 6 +++--- > contrib/remote-helpers/test-hg.sh => t/remote-helpers/hg.t | 4 ++-- > 10 files changed, 20 insertions(+), 24 deletions(-) > delete mode 100644 contrib/remote-helpers/Makefile > rename contrib/remote-helpers/git-remote-bzr => git-remote-bzr.py (100%) > rename contrib/remote-helpers/git-remote-hg => git-remote-hg.py (100%) > rename contrib/remote-helpers/test-bzr.sh => t/remote-helpers/bzr.t (98%) > rename contrib/remote-helpers/test-hg-bidi.sh => t/remote-helpers/hg-bidi.t (97%) > rename contrib/remote-helpers/test-hg-hg-git.sh => t/remote-helpers/hg-hg-git.t (98%) > rename contrib/remote-helpers/test-hg.sh => t/remote-helpers/hg.t (99%)