Re: [PATCH 2/2] remote-helpers: move tests out of contrib

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: Apr 21, 2014, 19:23 UTC
Message-ID: <53557021ed75d_414c80b30836@nysa.notmuch>
In-Reply-To: <xmqqy4yy8p0l.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

Show 12 quoted lines

> Felipe Contreras <felipe.contreras@gmail.com> writes:
> 
> >> This step needs a bit more work, I am afraid, to at least have these
> >> three test scripts follow the same numbering scheme.  Especially given
> >> that there were recent discussions on allowing a range of tests to
> >> be run (or omitted) via notations like "5000,5020,9800-9812", not
> >> doing so now will make it harder to implement such an enhancement.
> >
> > I don't see how such an enhancement would be beneficial to these remote
> > helpers.
> 
> Why are remote helpers more special than other parts of the system?

They aren't.

> Do they _have to_ be different and special?

No.

> > For starters there aren't any number rages left for them,...
> 
> Wouldn't "5 - the pull and exporting" be an obvious space for them,
> especiall somewhere after 5800?

Not _that_ obvious. If you are OK with having the hg-hg-git test (a test which requires hg-git, a tool that is completely independent from git-remote-hg) there, then fine.

-- 
Felipe Contreras