Re: [PATCH v2 1/2] create_default_files(): don't set u+x bit on $GIT_DIR/config

From

Junio C Hamano <gitster@pobox.com>

Date

Nov 17, 2014, 15:42 UTC

Message-ID

<xmqqbno5zvdm.fsf@gitster.dls.corp.google.com>

In-Reply-To

<5469C40B.4080601@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

> This seems like a one-off bug caused by a specific instance of odd code.
> It could only recur if somebody were to remove the line that I added,
> which would be a *very* odd mistake to make given that its purpose is
> pretty obvious.

You cannot anticipate what mistake others make.

Shouldn't something like this be sufficient?

 t/t0001-init.sh | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/t/t0001-init.sh b/t/t0001-init.sh
index e62c0ff..acdc1df 100755
--- a/t/t0001-init.sh
+++ b/t/t0001-init.sh
@@ -12,6 +12,13 @@ check_config () {
 		echo "expected a directory $1, a file $1/config and $1/refs"
 		return 1
 	fi
+
+	if ! test_have_prereq POSIXPERM || test -x "$1/config"
+	then
+		echo "$1/config is executable?"
+		return 1
+	fi
+
 	bare=$(cd "$1" && git config --bool core.bare)
 	worktree=$(cd "$1" && git config core.worktree) ||
 	worktree=unset