[PATCH v2 0/2] Don't make $GIT_DIR executable
- From
Michael Haggerty <mhagger@alum.mit.edu>
- Date
- Nov 16, 2014, 07:21 UTC
- Message-ID
- <1416122508-30654-1-git-send-email-mhagger@alum.mit.edu>
Changes since v1 [1]:
* Check the chmod() return result in create_default_files(), as suggested by Torsten Bögershausen.
* Fix a comment typo found by Stefan Beller.
* Extend patch 2/2 to also clearing the executable bits when "git config --edit" is run.
* Add test cases to patch 2/2 that the executable bits really are cleaned up when they should be.
Thanks to Stefan Beller, Torsten Bögershausen, and Eric Wong for their feedback about v1.
I have also pushed this series to my GitHub fork [2].
Please remember that this patch series applies to maint. This version has a couple of conflicts with master; I have pushed my proposed conflict resolution to GitHub [3], including a preparatory commit that I recommend for master.
[1] http://thread.gmane.org/gmane.comp.version-control.git/259620/focus=259620 [2] https://github.com/mhagger/git branch "config-non-executable" [3] https://github.com/mhagger/git branch "config-non-executable-merge"
Michael Haggerty (2): create_default_files(): don't set u+x bit on $GIT_DIR/config config: clear the executable bits (if any) on $GIT_DIR/config
builtin/config.c | 21 ++++++++++++++++++--- builtin/init-db.c | 1 + config.c | 12 ++++++++++-- t/t1300-repo-config.sh | 13 +++++++++++++ 4 files changed, 42 insertions(+), 5 deletions(-)
-- 2.1.1