git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/2] Don't make $GIT_DIR executable

From
Michael Haggerty <mhagger@alum.mit.edu>
Date
Nov 16, 2014, 07:21 UTC
Message-ID
<1416122508-30654-1-git-send-email-mhagger@alum.mit.edu>
Changes since v1 [1]:
* Check the chmod() return result in create_default_files(), as
  suggested by Torsten Bögershausen.
* Fix a comment typo found by Stefan Beller.
* Extend patch 2/2 to also clearing the executable bits when "git
  config --edit" is run.
* Add test cases to patch 2/2 that the executable bits really are
  cleaned up when they should be.

Thanks to Stefan Beller, Torsten Bögershausen, and Eric Wong for their feedback about v1.

I have also pushed this series to my GitHub fork [2].

Please remember that this patch series applies to maint. This version has a couple of conflicts with master; I have pushed my proposed conflict resolution to GitHub [3], including a preparatory commit that I recommend for master.

[1] http://thread.gmane.org/gmane.comp.version-control.git/259620/focus=259620 [2] https://github.com/mhagger/git branch "config-non-executable" [3] https://github.com/mhagger/git branch "config-non-executable-merge"

Michael Haggerty (2):
  create_default_files(): don't set u+x bit on $GIT_DIR/config
  config: clear the executable bits (if any) on $GIT_DIR/config
 builtin/config.c       | 21 ++++++++++++++++++---
 builtin/init-db.c      |  1 +
 config.c               | 12 ++++++++++--
 t/t1300-repo-config.sh | 13 +++++++++++++
 4 files changed, 42 insertions(+), 5 deletions(-)
-- 
2.1.1
Next: Michael Haggerty
Message 1 of 14 in “Don't make $GIT_DIR executable”
  1. 0/2 Don't make $GIT_DIR executableMichael Haggerty, Nov 16, 2014
  2. 1/2 create_default_files(): don't set u+x bit on $GIT_DIR/configMichael Haggerty, Nov 16, 2014
  3. Junio C HamanoNov 16, 2014
  4. Michael HaggertyNov 17, 2014
  5. Eric SunshineNov 17, 2014
  6. Torsten BögershausenNov 17, 2014
  7. Michael HaggertyNov 17, 2014
  8. Michael HaggertyNov 17, 2014
  9. Junio C HamanoNov 17, 2014
  10. Michael HaggertyNov 17, 2014
  11. Junio C HamanoNov 17, 2014
  12. 2/2 config: clear the executable bits (if any) on $GIT_DIR/configMichael Haggerty, Nov 16, 2014
  13. Johannes SixtNov 16, 2014
  14. Michael HaggertyNov 17, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.