Re: [PATCHv2] branch -d: test if we can delete broken refs

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2014, 18:43 UTC
Message-ID: <xmqqbnntreer.fsf@gitster.dls.corp.google.com>
In-Reply-To: <547593FF.6040507@alum.mit.edu>

Michael Haggerty <mhagger@alum.mit.edu> writes:

Show 5 quoted lines

> ... On the other hand, this is kind of an "aspirational test"; I don't
> know that the tested functionality has ever worked or that anybody has
> ever claimed that it works. So my feeling is that the addition of the
> test would feel more natural in the patch series that implements the new
> feature. But I don't feel strongly about it.

I share your feeling.

In the "aspiration followed by realization" pattern, the realization commit shows a change in t/ hierarchy that turns test_expect_failure into test_expect_success and it is likely that what is being tested will fall outside the context. Unless the test title is phrased very well, it would not be obvious from the patch text to the t/ hierarchy alone what behaviour is being corrected when looking at the realization commit.

If aspiration and realization are in a same series, that would not be a problem, but it is if the commits that add "aspirational test" and "realization" are too far apart.

If it is pretty clear to everybody that another topic to realize the aspiration will be coming in a not so distant future, I think it is fine, though.