Re: [PATCH] t1402: check to delete broken refs

From: Stefan Beller <sbeller@google.com>
Date: Nov 26, 2014, 00:42 UTC
Message-ID: <CAGZ79kao0CpeidBzVL4O-4jfNd7nGbOJwtvsJCEgOjb370z8uw@mail.gmail.com>
In-Reply-To: <20141126003506.GA19239@google.com>

On Tue, Nov 25, 2014 at 4:35 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:

Show 11 quoted lines

> Hi,
>
> Stefan Beller wrote:
>
>> This was also part of the ongoing series from Ronnie.
>> But I think the patch in this form is rather independant,
>> documenting the current state of "git branch -d", so it's
>> fine to have it in now.
>
> Is there a patch adding the feature this patch describes that this
> could be squashed into?

I have extracted it actually from a patch, which it was part of. I want to send as much uncontroversial stuff to the list, before I try another round of the larger reflog transactions series.

For now this test just documents, how git branch is behaving differently from its desired behavior. So it is also a subtle proposal how the desired behavior should look like. (Deleting broken branches without further questioning, flags or other magic incantations)

Show 7 quoted lines

>
>>  t/t1402-check-ref-format.sh | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>
> This doesn't have anything to do with check-ref-format --- it's about
> how easy it is to recover from a repository with corrupt files in it.
> Would it fit somewhere like t3200-branch.sh?

I'll look into placing this test in a more appropriate spot.