git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3] gettext.h: add parentheses around N_ expansion if supported

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 12, 2015, 19:08 UTC
Message-ID
<xmqqbnm395qz.fsf@gitster.dls.corp.google.com>
In-Reply-To
<47914a9078cc9d272204ec00825d67f@74d39fa044aa309eaea14b9f57fe79c>
"Kyle J. McKay" <mackyle@gmail.com> writes:
> The "yes", "no", "auto" settings for the new Makefile configuration
> variable "USE_PARENS_AROUND_GETTEXT_N" are based on the way the
> Makefile variable "COMPUTE_HEADER_DEPENDENCIES" works.  So I used
> "yes" and "no" for consistency instead of "Yes" and "No".
Thanks for a careful execution of my clumsy illustration.
> +# and define it to "no" if you need to remove the parentheses () around the
> +# constant.  The default is "auto", which means to use parentheses if your
> +# compiler is detected to support it.

Strictly speaking, s/detected to/most likely to/, as we are only checking "__GNUC__", but we can leave the phrasing as-is and wait until somebody complains.

Thanks.
Previous: Kyle J. McKay
Message 2 of 2 in “gettext.h: add parentheses around N_ expansion if supported”
  1. gettext.h: add parentheses around N_ expansion if supportedKyle J. McKay, Jan 11, 2015
  2. Junio C HamanoJan 12, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.