From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 12 Jan 2015 19:08:20 GMT
Subject: Re: [PATCH v3] gettext.h: add parentheses around N_ expansion if supported
Message-ID: <xmqqbnm395qz.fsf@gitster.dls.corp.google.com>
In-Reply-To: <47914a9078cc9d272204ec00825d67f@74d39fa044aa309eaea14b9f57fe79c>

"Kyle J. McKay" <mackyle@gmail.com> writes:

> The "yes", "no", "auto" settings for the new Makefile configuration
> variable "USE_PARENS_AROUND_GETTEXT_N" are based on the way the
> Makefile variable "COMPUTE_HEADER_DEPENDENCIES" works.  So I used
> "yes" and "no" for consistency instead of "Yes" and "No".

Thanks for a careful execution of my clumsy illustration.

> +# and define it to "no" if you need to remove the parentheses () around the
> +# constant.  The default is "auto", which means to use parentheses if your
> +# compiler is detected to support it.

Strictly speaking, s/detected to/most likely to/, as we are only
checking "__GNUC__", but we can leave the phrasing as-is and wait
until somebody complains.

Thanks.