git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] parse_color: fix return value for numeric color values 0-8

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 21, 2015, 00:36 UTC
Message-ID
<xmqqbnltynpm.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20150121000352.GA12543@peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
>> Thanks; somebody should have caught this before we applied and
>> merged to 'master', but the process obviously did not work well.
>
> I am not too surprised. The use of numeric values for colors was
> completely undocumented, and we did not have any test coverage for it. I
> did not even know it existed until I started refactoring the function,
> and wondered what was going on (though I did try to preserve it once I
> found it).

I was specifically thinking about the failure of "eyeball test". I often do "git am" followed by "git show -U20" to check the change in context, which _should_ have caught the lack of return there.

Previous: Jeff King
Message 7 of 7 in “[ANNOUNCE] Git v2.3.0-rc0”
  1. Junio C HamanoJan 12, 2015
  2. Christian NeukirchenJan 14, 2015
  3. Ævar Arnfjörð BjarmasonJan 20, 2015
  4. parse_color: fix return value for numeric color values 0-8Jeff King, Jan 20, 2015
  5. Junio C HamanoJan 20, 2015
  6. Jeff KingJan 21, 2015
  7. Junio C HamanoJan 21, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.