From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 21 Jan 2015 00:36:05 GMT
Subject: Re: [PATCH] parse_color: fix return value for numeric color values 0-8
Message-ID: <xmqqbnltynpm.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20150121000352.GA12543@peff.net>

Jeff King <peff@peff.net> writes:

>> Thanks; somebody should have caught this before we applied and
>> merged to 'master', but the process obviously did not work well.
>
> I am not too surprised. The use of numeric values for colors was
> completely undocumented, and we did not have any test coverage for it. I
> did not even know it existed until I started refactoring the function,
> and wondered what was going on (though I did try to preserve it once I
> found it).

I was specifically thinking about the failure of "eyeball test".
I often do "git am" followed by "git show -U20" to check the change
in context, which _should_ have caught the lack of return there.