git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 00/11] Allow reference values to be checked in a transaction

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 9, 2015, 20:45 UTC
Message-ID
<xmqqbnl2bypl.fsf@gitster.dls.corp.google.com>
In-Reply-To
<54D91B24.5050808@alum.mit.edu>
Michael Haggerty <mhagger@alum.mit.edu> writes:
Show 30 quoted lines
> On 02/09/2015 08:05 PM, Stefan Beller wrote:
>> On Mon, Feb 9, 2015 at 10:41 AM, Junio C Hamano <gitster@pobox.com> wrote:
>>> Michael Haggerty <mhagger@alum.mit.edu> writes:
>>>> [...]
>>>> This patch series applies on top of master merged together with
>>>> sb/atomic-push, which in turn depends on mh/reflog-expire.
>>>
>>> I am a bit puzzled by your intentions, so help me out.
>>>
>>> I see that your understanding is that Stefan will be rerolling the
>>> push atomicity thing; wouldn't we then want to have a "fix and
>>> clean" topic like this one first and build the push atomicity thing
>>> on top instead?
>> 
>> My understanding is to not reroll origin/sb/atomic-push, but
>> origin/sb/atomic-push-fix (which is worded misleading. It is not about
>> atomic pushes, but about enabling large transactions in my understanding)
>
> Yes, that is what I thought.
> ...
> Both series have to do with reflogs, but they are logically pretty
> independent. In particular, "Fix some problems with reflog expiration"
> fixes problems that existed before mh/reflog-expire. And considering
> that one topic is quite mature whereas the the other is just making its
> debut, it seemed like yoking them together would slow down the first
> topic for no good reason.
> ...
> I expected that mh/reflog-expire and sb/atomic-push would be merged
> pretty early in the 2.4 cycle (they are both in next already). Junio, is
> that not your plan?

OK, I am glad I asked for clarifications. It was that I felt uneasy to see many new "this cleans and fixes" while there are in-flight topics in the same area.

Thanks.
Previous: Stefan Beller
Message 35 of 35 in “Allow reference values to be checked in a transaction”
  1. 00/11 Allow reference values to be checked in a transactionMichael Haggerty, Feb 8, 2015
  2. 01/11 refs: move REF_DELETING to refs.cMichael Haggerty, Feb 8, 2015
  3. Stefan BellerFeb 9, 2015
  4. 02/11 refs: remove the gap in the REF_* constant valuesMichael Haggerty, Feb 8, 2015
  5. Stefan BellerFeb 9, 2015
  6. 03/11 struct ref_update: move "have_old" into "flags"Michael Haggerty, Feb 8, 2015
  7. 04/11 ref_transaction_update(): remove "have_old" parameterMichael Haggerty, Feb 8, 2015
  8. Stefan BellerFeb 9, 2015
  9. Michael HaggertyFeb 11, 2015
  10. 05/11 ref_transaction_delete(): remove "have_old" parameterMichael Haggerty, Feb 8, 2015
  11. Stefan BellerFeb 9, 2015
  12. 06/11 commit: add tests of commit racesMichael Haggerty, Feb 8, 2015
  13. Stefan BellerFeb 9, 2015
  14. Junio C HamanoFeb 10, 2015
  15. Michael HaggertyFeb 11, 2015
  16. Junio C HamanoFeb 11, 2015
  17. Stefan BellerFeb 11, 2015
  18. Junio C HamanoFeb 11, 2015
  19. 07/11 commit: avoid race when creating orphan commitsMichael Haggerty, Feb 8, 2015
  20. Stefan BellerFeb 9, 2015
  21. Michael HaggertyFeb 11, 2015
  22. 08/11 ref_transaction_create(): check that new_sha1 is validMichael Haggerty, Feb 8, 2015
  23. Stefan BellerFeb 9, 2015
  24. 09/11 ref_transaction_delete(): check that old_sha1 is not null_sha1Michael Haggerty, Feb 8, 2015
  25. Stefan BellerFeb 9, 2015
  26. 10/11 ref_transaction_verify(): new function to check a reference's valueMichael Haggerty, Feb 8, 2015
  27. Stefan BellerFeb 9, 2015
  28. Michael HaggertyFeb 11, 2015
  29. 11/11 update_ref(): improve documentationMichael Haggerty, Feb 8, 2015
  30. Stefan BellerFeb 9, 2015
  31. Junio C HamanoFeb 9, 2015
  32. Stefan BellerFeb 9, 2015
  33. Michael HaggertyFeb 9, 2015
  34. Stefan BellerFeb 9, 2015
  35. Junio C HamanoFeb 9, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.