Re: [PATCH v9 01/20] ref-filter: implement %(if), %(then), and %(else) atoms

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 27, 2016, 20:58 UTC
Message-ID: <xmqqbmvx842i.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20161227162357.28212-2-Karthik.188@gmail.com>

Karthik Nayak <karthik.188@gmail.com> writes:

Show 8 quoted lines

>  
> +Some atoms like %(align) and %(if) always require a matching %(end).
> +We call them "opening atoms" and sometimes denote them as %($open).
> +
> +When a scripting language specific quoting is in effect, everything
> +between a top-level opening atom and its matching %(end) is evaluated
> +according to the semantics of the opening atom and its result is
> +quoted.

What is unsaid in the last paragraph is that you assume "is evaluated according to the semantics of the opening atom" does not involve quoting and only the result from the top-level is quoted. I am not sure if that is clear to the first-time readers.

Show 10 quoted lines

>  
>  EXAMPLES
>  --------
> @@ -273,6 +291,22 @@ eval=`git for-each-ref --shell --format="$fmt" \
>  eval "$eval"
>  ------------
> ...
> +------------
> +git for-each-ref --format="%(refname)%(if)%(authorname)%(then) %(color:red)Authored by: %(authorname)%(end)"
> +------------

This makes readers wonder how "red"ness is reset, but that is not something this example is interested in demonstrating. Let's drop the %(color:red) bit to avoid distracting readers.