git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v9 18/20] branch, tag: use porcelain output

From
Karthik Nayak <karthik.188@gmail.com>
Date
Dec 27, 2016, 16:23 UTC
Message-ID
<20161227162357.28212-19-Karthik.188@gmail.com>
In-Reply-To
<20161227162357.28212-1-Karthik.188@gmail.com>
From: Karthik Nayak <karthik.188@gmail.com>

Call ref-filter's setup_ref_filter_porcelain_msg() to enable translated messages for the %(upstream:tack) atom. Although branch.c doesn't currently use ref-filter's printing API's, this will ensure that when it does in the future patches, we do not need to worry about translation.

Written-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
---
 builtin/branch.c | 2 ++
 builtin/tag.c    | 2 ++
 2 files changed, 4 insertions(+)
diff --git a/builtin/branch.c b/builtin/branch.c
index 6423ebc..34cd61c 100644
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -649,6 +649,8 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
 		OPT_END(),
 	};
 
+	setup_ref_filter_porcelain_msg();
+
 	memset(&filter, 0, sizeof(filter));
 	filter.kind = FILTER_REFS_BRANCHES;
 	filter.abbrev = -1;
diff --git a/builtin/tag.c b/builtin/tag.c
index b4789ce..8a1a476 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -375,6 +375,8 @@ int cmd_tag(int argc, const char **argv, const char *prefix)
 		OPT_END()
 	};
 
+	setup_ref_filter_porcelain_msg();
+
 	git_config(git_tag_config, sorting_tail);
 
 	memset(&opt, 0, sizeof(opt));
-- 
2.10.2
Previous: Karthik NayakNext: Karthik Nayak
Message 30 of 34 in “port branch.c to use ref-filter's printing options”
  1. 00/20 port branch.c to use ref-filter's printing optionsKarthik Nayak, Dec 27, 2016
  2. 01/20 ref-filter: implement %(if), %(then), and %(else) atomsKarthik Nayak, Dec 27, 2016
  3. Junio C HamanoDec 27, 2016
  4. Karthik NayakDec 28, 2016
  5. 03/20 ref-filter: implement %(if:equals=<string>) and %(if:notequals=<string>)Karthik Nayak, Dec 27, 2016
  6. Junio C HamanoDec 27, 2016
  7. Karthik NayakDec 28, 2016
  8. 02/20 ref-filter: include reference to 'used_atom' within 'atom_value'Karthik Nayak, Dec 27, 2016
  9. Junio C HamanoDec 27, 2016
  10. Karthik NayakDec 28, 2016
  11. 05/20 ref-filter: move get_head_description() from branch.cKarthik Nayak, Dec 27, 2016
  12. 04/20 ref-filter: modify "%(objectname:short)" to take lengthKarthik Nayak, Dec 27, 2016
  13. 06/20 ref-filter: introduce format_ref_array_item()Karthik Nayak, Dec 27, 2016
  14. 07/20 ref-filter: make %(upstream:track) prints "[gone]" for invalid upstreamsKarthik Nayak, Dec 27, 2016
  15. 08/20 ref-filter: add support for %(upstream:track,nobracket)Karthik Nayak, Dec 27, 2016
  16. 10/20 ref-filter: introduce refname_atom_parser_internal()Karthik Nayak, Dec 27, 2016
  17. 09/20 ref-filter: make "%(symref)" atom work with the ':short' modifierKarthik Nayak, Dec 27, 2016
  18. 12/20 ref-filter: make remote_ref_atom_parser() use refname_atom_parser_internal()Karthik Nayak, Dec 27, 2016
  19. 11/20 ref-filter: introduce refname_atom_parser()Karthik Nayak, Dec 27, 2016
  20. Junio C HamanoDec 27, 2016
  21. Karthik NayakDec 28, 2016
  22. 14/20 ref-filter: Do not abruptly die when using the 'lstrip=<N>' optionKarthik Nayak, Dec 27, 2016
  23. 13/20 ref-filter: rename the 'strip' option to 'lstrip'Karthik Nayak, Dec 27, 2016
  24. 15/20 ref-filter: modify the 'lstrip=<N>' option to work with negative '<N>'Karthik Nayak, Dec 27, 2016
  25. Junio C HamanoDec 27, 2016
  26. Jacob KellerDec 28, 2016
  27. Karthik NayakDec 28, 2016
  28. 16/20 ref-filter: add an 'rstrip=<N>' option to atoms which deal with refnamesKarthik Nayak, Dec 27, 2016
  29. 17/20 ref-filter: allow porcelain to translate messages in the outputKarthik Nayak, Dec 27, 2016
  30. 18/20 branch, tag: use porcelain outputKarthik Nayak, Dec 27, 2016
  31. 19/20 branch: use ref-filter printing APIsKarthik Nayak, Dec 27, 2016
  32. Junio C HamanoDec 27, 2016
  33. Karthik NayakDec 28, 2016
  34. 20/20 branch: implement '--format' optionKarthik Nayak, Dec 27, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.