Re: [PATCH] rebase: pass --signoff option to git am

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 23, 2017, 20:16 UTC
Message-ID: <xmqqbmuxr0pd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAOxFTcyuLkvgPOxQuzaDUVuDRu_KJg=JrYtU84pQyjLstChbLg@mail.gmail.com>

Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:

Show 8 quoted lines

> On Mon, Jan 23, 2017 at 7:13 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> Should we plan to extend this to the interactive backend that is
>> shared between rebase -i and rebase -m, too?  Or is this patch
>> already sufficient to cover them?
>
> AFAIK this is sufficient for both, in the sense that I've used it with
> git rebase -i and it works.

That is a good news and at the same time a bit awkard one ;-)

The mention of "passed to 'git am'" twice in the documentation and help text would lead people to think "rebase -i" would not be affected and (1) would need more work to do so, or (2) the user does not want "rebase -i" to be unaffected for whatever reason, and gets surprised to see that it actually does get affected.

In any case, will queue as-is so that we won't lose the patch while waiting for people to raise their opinions.

Thanks.