Re: [PATCH] rebase: pass --signoff option to git am

From: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Date: Jan 24, 2017, 07:06 UTC
Message-ID: <CAOxFTcwDK6tdb7xjemoxJ7rgEa9S-Ub9ZdrCEJFw98r0cUXRmw@mail.gmail.com>
In-Reply-To: <xmqqsho9pdbc.fsf@gitster.mtv.corp.google.com>

On Tue, Jan 24, 2017 at 12:27 AM, Junio C Hamano <gitster@pobox.com> wrote:

Show 16 quoted lines

> Giuseppe Bilotta <giuseppe.bilotta@gmail.com> writes:
>>
>> I'm not sure I follow. If the user doesn't want to signoff during a
>> rebase, they can simply not pass --signoff. If they do, they can not
>> pass it. Am I missing something?
>
> alias.
>
> Which also means that there needs to be --no-signoff option that can
> be given to countermand an earlier --signoff, if a user did
>
>         [alias] rb = rebase --signoff
>
> and wants to disable it one time only with
>
>         $ git rb --no-signoff

Oh, right, good point. This should be easy, I'll give this a go.

Show 8 quoted lines

>>> In any case, will queue as-is so that we won't lose the patch while
>>> waiting for people to raise their opinions.
>>
>> Thanks.
>
> Thanks.  The final version would also need tests, so it may be a
> good time to start thinking about what aspect of this feature wants
> to be protected against future breakages.

I have troubles thinking how it could go wrong. The most obvious thing I can think of is it could not be remembered after an interruption+continue. I'll think about this some more.

-- 
Giuseppe "Oblomov" Bilotta