Re: Possible bug in includeIf / conditional includes

From: Junio C Hamano <gitster@pobox.com>
Date: May 11, 2017, 07:54 UTC
Message-ID: <xmqqbmqzbzh0.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170511074257.xueofze3dv3xwrql@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 10 quoted lines

> On Thu, May 11, 2017 at 09:19:50AM +0200, Ævar Arnfjörð Bjarmason wrote:
>
>> 1. It says "The included file is expanded immediately, as if its
>> contents had been found at the location of the include directive.". At
>> first I thought this referred to glob expansion, not
>> s/expanded/interpolated/, the example section uses "expand" in the
>> context of pathnames, which caused the confusion.
>
> Perhaps it should say "The contents of the included file are expanded
> immediately, as if they had been found at..."?

Or s/expanded/inserted/, perhaps? The word "expand" does not quite click to me in this context. Just like Ævar, I associate the word with an act of replacing some template-with-blank with the result of blanks-in-the-template-filled.

Regarding 2. and 3., I agree with your comments.

Thanks.