Re: Possible bug in includeIf / conditional includes

From: Jeff King <peff@peff.net>
Date: May 11, 2017, 06:29 UTC
Message-ID: <20170511062924.6euaynsbyocjcw3q@sigill.intra.peff.net>
In-Reply-To: <20170511062616.f7rg6f5cgrqeh7gf@sigill.intra.peff.net>

On Thu, May 11, 2017 at 02:26:16AM -0400, Jeff King wrote:

Show 11 quoted lines

> > So whether this is a bug in the code or not it seems to definitely be
> > a doc bug, whatever it does with relative files should be in the docs.
> 
> The includeIf variables should behave exactly as the documentation you
> quoted above. The conditional impacts whether we respect the keys in
> that section, but not the meaning of the keys.
> 
> I thought that was clear, but as somebody who was involved in the
> development of both the original and the conditional includes, my
> opinion probably doesn't count. I wouldn't mind a patch to make that
> more explicit in the documentation.

I figured I'd just do this while we're thinking about it, since it should be trivial. But it's actually there already:

  You can include a config file from another conditionally by setting a
  `includeIf.<condition>.path` variable to the name of the file to be
  included. The variable's value is treated the same way as
  `include.path`.

I'm open to suggestions to make that more obvious, though.

-Peff