Re: Request for git merge --signoff

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2017, 17:45 UTC
Message-ID: <xmqqbmp4nj9u.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAHv71zK5SqbwrBFX=a8-DY9H3KT4FEyMgv__p2gZzNr0WUAPUw@mail.gmail.com>

Dan Kohn <dan@linuxfoundation.org> writes:

Show 16 quoted lines

> This alternative workflow works, but is obviously tedious:
>
> ```sh
> # First 3 steps are the same
> (feature-branch)$ git merge origin/master
> # Save default commit message
> (feature-branch)$ git commit --amend -s
> # Commit message now has signoff line
> (feature-branch)$ git push
> # This now passes the DCObot check.
> ```
>
> Or, I could manually add the Signoff line to the proposed git merge
> commit message, which would allow me to skip the `--amend` step.
>
> Could you please add a `--signoff` option to `git merge`?

The reason why we changed the default for "git merge" to start an editor at around v1.7.10 was because we wanted to encourage people to write log message that more meaningfully documents the change, and adding sign-off is probably in line with that.

I've done that "commit --amend" on a merge to tweak its message myself number of times, but I have to admit that I never did so for sign-off, but why not? ;-)