Re: Request for git merge --signoff

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 1, 2017, 20:25 UTC
Message-ID: <xmqq7ezroqfa.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAHv71zJZfG3AGNL_J5KqYiut6AyyNdUyBG-sZ9aZ-zoGVdOr+w@mail.gmail.com>

Dan Kohn <dan@linuxfoundation.org> writes:

Show 17 quoted lines

> On Sat, Jul 1, 2017 at 1:45 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Dan Kohn <dan@linuxfoundation.org> writes:
>
>>> Could you please add a `--signoff` option to `git merge`?
>
>> The reason why we changed the default for "git merge" to start an
>> editor at around v1.7.10 was because we wanted to encourage people
>> to write log message that more meaningfully documents the change,
>> and adding sign-off is probably in line with that.
>
>> I've done that "commit --amend" on a merge to tweak its message
>> myself number of times, but I have to admit that I never did so for
>> sign-off, but why not? ;-)
>
> I'm not opposed to starting the editor, although ...
> ...
> Even if you turn down my request for a new flag here,...

Was I a bit too oblique? I said that do think "merge --signoff" is in line with the latest philosophy, i.e. not rejecting the idea of add such an option. IOW, patches welcome (either from you or other people).