Re: [PATCH/FIXUP 6/2] apply: clarify read_old_data() is about no-index case

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 17, 2017, 07:12 UTC
Message-ID: <xmqqbmneis63.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20170817062450.GA28592@tor.lan>

Torsten Bögershausen <tboegi@web.de> writes:

> Unless we re-define the meaning of "NULL" into "don't do CRLF conversions,
> like SAFE_CRLF_KEEP_CRLF does.

My preference is not to use NULL as any hint. Instead, the "flag" parameter we already pass to convert_to_git(), just like the updated read_old_data() uses SAFE_CRLF_KEEP_CRLF to tell it that it should not disturb existing CRLF without looking at the istate, should be used to tell convert_to_git() to do the opposite, but do so without looking at the istate.

Perhaps SAFE_CRLF_FALSE should be such a flag. Or perhaps we need to invent another flag. I dunno.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.