Re: [PATCH/FIXUP 6/2] apply: clarify read_old_data() is about no-index case
- From
Torsten Bögershausen <tboegi@web.de>
- Date
- Aug 17, 2017, 08:24 UTC
- Message-ID
- <20170817082435.GA7508@tor.lan>
- In-Reply-To
- <xmqqbmneis63.fsf@gitster.mtv.corp.google.com>
On Thu, Aug 17, 2017 at 12:12:36AM -0700, Junio C Hamano wrote:
Show 14 quoted lines
> Torsten Bögershausen <tboegi@web.de> writes: > > > Unless we re-define the meaning of "NULL" into "don't do CRLF conversions, > > like SAFE_CRLF_KEEP_CRLF does. > > My preference is not to use NULL as any hint. Instead, the "flag" > parameter we already pass to convert_to_git(), just like the updated > read_old_data() uses SAFE_CRLF_KEEP_CRLF to tell it that it should > not disturb existing CRLF without looking at the istate, should be > used to tell convert_to_git() to do the opposite, but do so without > looking at the istate. > > Perhaps SAFE_CRLF_FALSE should be such a flag. Or perhaps we need > to invent another flag. I dunno.
OK, message taken, in short: I will come up with a new series in a couple of days - thanks for the input.