Re: [PATCH] completion: use builtin completion for format-patch
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 30, 2018, 02:20 UTC
- Message-ID
- <xmqqbm7c2n0i.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <31160e8c63399e8c866eef40462d0b699bae9b59.1540835698.git.liu.denton@gmail.com>
Denton Liu <liu.denton@gmail.com> writes:
> Signed-off-by: Denton Liu <liu.denton@gmail.com> > --- > contrib/completion/git-completion.bash | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-)
We saw a similar change proposed and then found out it was not such a good idea in:
https://public-inbox.org/git/CACsJy8DUrVJu0HN7kuCeo4iV5aimWbYtr+E-7kenPVDx90DpGw@mail.gmail.com/
It seems that this one loses options like --full-index, --no-prefix, etc. compared to the earlier effort?
Show 29 quoted lines
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index d63d2dffd..da77da481 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1531,15 +1531,6 @@ _git_fetch ()
> __git_complete_remote_or_refspec
> }
>
> -__git_format_patch_options="
> - --stdout --attach --no-attach --thread --thread= --no-thread
> - --numbered --start-number --numbered-files --keep-subject --signoff
> - --signature --no-signature --in-reply-to= --cc= --full-index --binary
> - --not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=
> - --inline --suffix= --ignore-if-in-upstream --subject-prefix=
> - --output-directory --reroll-count --to= --quiet --notes
> -"
> -
> _git_format_patch ()
> {
> case "$cur" in
> @@ -1550,7 +1541,7 @@ _git_format_patch ()
> return
> ;;
> --*)
> - __gitcomp "$__git_format_patch_options"
> + __gitcomp_builtin format-patch
> return
> ;;
> esac