git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion: use builtin completion for format-patch

From
Denton Liu <liu.denton@gmail.com>
Date
Oct 29, 2018, 17:57 UTC
Message-ID
<31160e8c63399e8c866eef40462d0b699bae9b59.1540835698.git.liu.denton@gmail.com>
Signed-off-by: Denton Liu <liu.denton@gmail.com>
---
 contrib/completion/git-completion.bash | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index d63d2dffd..da77da481 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1531,15 +1531,6 @@ _git_fetch ()
 	__git_complete_remote_or_refspec
 }
 
-__git_format_patch_options="
-	--stdout --attach --no-attach --thread --thread= --no-thread
-	--numbered --start-number --numbered-files --keep-subject --signoff
-	--signature --no-signature --in-reply-to= --cc= --full-index --binary
-	--not --all --cover-letter --no-prefix --src-prefix= --dst-prefix=
-	--inline --suffix= --ignore-if-in-upstream --subject-prefix=
-	--output-directory --reroll-count --to= --quiet --notes
-"
-
 _git_format_patch ()
 {
 	case "$cur" in
@@ -1550,7 +1541,7 @@ _git_format_patch ()
 		return
 		;;
 	--*)
-		__gitcomp "$__git_format_patch_options"
+		__gitcomp_builtin format-patch
 		return
 		;;
 	esac
-- 
2.19.1
Next: Junio C Hamano
Message 1 of 13 in “completion: use builtin completion for format-patch”
  1. completion: use builtin completion for format-patchDenton Liu, Oct 29, 2018
  2. Junio C HamanoOct 30, 2018
  3. Denton LiuOct 30, 2018
  4. completion: use builtin completion for format-patchDenton Liu, Oct 30, 2018
  5. Junio C HamanoOct 30, 2018
  6. Duy NguyenOct 30, 2018
  7. Junio C HamanoNov 1, 2018
  8. Duy NguyenNov 1, 2018
  9. Junio C HamanoNov 1, 2018
  10. Duy NguyenNov 3, 2018
  11. Denton LiuNov 3, 2018
  12. Duy NguyenNov 3, 2018
  13. Junio C HamanoNov 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.