Re: [PATCH v6 4/6] blame: add config options to handle output for ignored lines

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 14, 2019, 10:24 UTC
Message-ID: <xmqqbm18x4tt.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <CAJDYR9S8XFH=JnQX8WcfgOZ7cr+X6kk45k9g8t3u5aP5wwdu0Q@mail.gmail.com>

Michael Platings <michael@platin.gs> writes:

> If you only enable blame.markIgnoredLines then the hash for
> "unblamable" lines appears as e.g. "*3252488f5" - this doesn't seem
> right to me because the commit *wasn't* ignored,

I think you misunderstood me. I was merely suggesting to use the approach to mark the line in a way other than using the NULLed out object name that has been reserved for something totally different, and hinting with "the same *idea*".

And that idea is not even original to this series; the "^" marker that is used to say "the line is attributed to this commit, but that may only be because you blamed with commit range A..B and we reached the bottom of the range---if you dug further, you might find the line originates from another commit" is the origin of the same idea, and this topic borrows it and uses a different mark, i.e. '*', for the "we are not certain---take this with grain of salt" mark.

If you ended up hitting the commit the user wanted to ignore, perhaps you can find another character that is different from '^' or '*' and use that, following the same idea.

That is what I meant. So you shouldn't be worried about using the same '*' making the result ambiguous.

By the way, a configuration only feature is something we usually do not accept. A feature must be guarded with --command-line-option and then optionally can have a corresponding configuration once the option proves to be useful enough that it becomes useful to be able to say "in this repository (or to this user), the feature is on by default".