Re: [PATCH v6 3/6] blame: add the ability to ignore commits and their changes

From: Michael Platings <michael@platin.gs>
Date: Apr 14, 2019, 10:42 UTC
Message-ID: <CAJDYR9Q-ixsxWyMrm7aCojTv33SOj3+ALPwJYo9DJE7vLU=DEA@mail.gmail.com>
In-Reply-To: <878swhfzxb.fsf@evledraar.gmail.com>

Show 8 quoted lines

> > +     the `blame.ignoreRevsFile` config option.  An empty file name, `""`, will
> > +     clear the list of revs from previously processed files.
>
> Maybe I haven't read this carefully enough but the use-case for this
> doesn't seem to be explained, you need this for the option, but the
> config file too? If I want to override fsck.skipList I do
> `fsck.skipList=/dev/zero`. Isn't that enough for this use-case without
> introducing config state-machine magic?

The difference between blame.ignoreRevsFile and fsck.skipList is that ignoreRevsFile can be specified repeatedly. This is useful if you have one file listing reformatting commits, another listing renaming commits etc. Or maybe a checked-in list of commits to ignore, and a personal list of commits to ignore. However sometimes you're going to want to *not* ignore those commits, so you need a way to discard the previously specified options. To accommodate all operating systems an empty string seems the best way to do this.