Re: [PATCH v4 01/11] commit-graph: fix the_repository reference

From: Junio C Hamano <gitster@pobox.com>
Date: May 13, 2019, 02:56 UTC
Message-ID: <xmqqbm07dptx.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <0be7713a255d6f52c51ccb19299d0c9797e9a03f.1557411749.git.gitgitgadget@gmail.com>

"Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Derrick Stolee <dstolee@microsoft.com>
>
> The parse_commit_buffer() method takes a repository pointer, so it
> should not refer to the_repository anymore.

Yup, makes sense.  Thanks for spotting.

Show 19 quoted lines

>
> Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> ---
>  commit.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/commit.c b/commit.c
> index a5333c7ac6..e4d1233226 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -443,7 +443,7 @@ int parse_commit_buffer(struct repository *r, struct commit *item, const void *b
>  	item->date = parse_commit_date(bufptr, tail);
>  
>  	if (check_graph)
> -		load_commit_graph_info(the_repository, item);
> +		load_commit_graph_info(r, item);
>  
>  	return 0;
>  }