Re: [PATCH v3 0/6] Create commit-graph file format v2
- From
Christian Couder <christian.couder@gmail.com>
- Date
- May 6, 2019, 08:27 UTC
- Message-ID
- <CAP8UFD2tnkNfgjm=H__=YPG-+BuOHwHs9=OoXnL9wnj_eOtbQg@mail.gmail.com>
- In-Reply-To
- <87bm0jirjj.fsf@evledraar.gmail.com>
On Fri, May 3, 2019 at 3:44 PM Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:
Show 11 quoted lines
> > > On Fri, May 03 2019, Derrick Stolee wrote: > > > On 5/2/2019 2:02 PM, Ævar Arnfjörð Bjarmason wrote: > >> > >> But those are separate from any back-compat concerns, which is what I > >> think makes sense to focus on now. > > > > Thinking more on this topic, I think I have a way to satisfy _all_ of > > your concerns by simplifying the plan for incremental commit-graph files.
[...]
Show 11 quoted lines
> Just on this, consider storing them in > .git/objects/info/commit-graphs/commit-graph-<THIS-FILE'S-CHECKSUM-SHA1>, > because: > > 1) We can stat() the "commit-graphs" directory to see if there's any > new/deleted ones (dir mtime changed), similar to what we do for the > untracked cache, and can (but I don't think we do...) do for packs/* > and objects/??/. > > As opposed to ".git/objects/info" itself which e.g. has the "packs", > "alternates" etc. files (can still do it, but more false positives)
About incremental commit-graph files and alternates, I wonder if they could work well together. The main use case would be for servers that use a common repo for all the forks.