Re: [PATCH v3 1/5] t4001: add a test comparing basename similarity and content similarity
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 13, 2021, 23:56 UTC
- Message-ID
- <xmqqblcnttcr.fsf@gitster.c.googlers.com>
- In-Reply-To
- <CABPp-BHyYOAw939vU20oA_tOSFRVm=EaLKuw+4M1oP1GDDV5cg@mail.gmail.com>
Elijah Newren <newren@gmail.com> writes:
Show 5 quoted lines
> This is not true. If src/main.c is 99% similar to src/foo.c, and is > 0% similar to the src/main.c in the new commit, we match the old > src/main.c to the new src/main.c despite being far more similar > src/foo.c. Unless break detection is turned on, we do not allow > content similarity to trump (full) filename equality.
Absolutely. And we are talking about a new optimization that kicks in only when there is no break or no copy detection going on, no?