Re: lh/use-gnu-color-in-grep, was Re: What's cooking in git.git (Jan 2022, #01; Mon, 3)

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 4, 2022, 20:11 UTC
Message-ID: <xmqqbl0rcld1.fsf@gitster.g>
In-Reply-To: <25d00bcb-3345-c221-6a38-593f23f942f3@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 9 quoted lines

>> FWIW I am in favor of adjusting Git's `grep` colors to GNU's
>> version. From
>> the users' perspective, it provides more consistency and less unexpected
>> surprises.
>
> For what it's worth, I'm also in favor of that change. It's been
> in my todo list of possible enhancements for a little while. I
> agree with Dscho that it's more consistent for users to have the
> same default colors as GNU grep.

I am not a huge fan of adjusting our defaults to other people's default, since they can match ours to "have the same default", if they wanted to. Also we are risking complaints from those who would say "We've been happily using the default coloring, and you suddenly changed it to something ugly. We want our color back and we do not care that now you match what GNU does".

But it seems that I won't have to be the one who need to field such complaints, and instead we have at least two well-known people in the list who volunteered for the role, so let's take it as-is.