Re: lh/use-gnu-color-in-grep, was Re: What's cooking in git.git (Jan 2022, #01; Mon, 3)

From: Philippe Blain <levraiphilippeblain@gmail.com>
Date: Jan 4, 2022, 18:06 UTC
Message-ID: <25d00bcb-3345-c221-6a38-593f23f942f3@gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.2201041458150.7076@tvgsbejvaqbjf.bet>

Hi Junio,

Le 2022-01-04 à 08:59, Johannes Schindelin a écrit :

Show 18 quoted lines

> Hi Junio,
> 
> On Mon, 3 Jan 2022, Junio C Hamano wrote:
> 
>> * lh/use-gnu-color-in-grep (2021-12-16) 1 commit
>>   - grep: align default colors with GNU grep ones
>>
>>   The color palette used by "git grep" has been updated to match that
>>   of GNU grep.
>>
>>   On hold.
>>   cf. <xmqqh7b88b3o.fsf@gitster.g>
>>   source: <20211216115622.85506-1-lenaic@lhuard.fr>
> 
> FWIW I am in favor of adjusting Git's `grep` colors to GNU's version. From
> the users' perspective, it provides more consistency and less unexpected
> surprises.
>

For what it's worth, I'm also in favor of that change. It's been in my todo list of possible enhancements for a little while. I agree with Dscho that it's more consistent for users to have the same default colors as GNU grep.

Cheers, Philippe.