Re: What's cooking in git.git (Mar 2022, #02; Mon, 7)
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Mar 9, 2022, 19:14 UTC
- Message-ID
- <xmqqbkyfkkes.fsf@gitster.g>
- In-Reply-To
- <20220308080551.18538-1-dyroneteng@gmail.com>
Teng Long <dyroneteng@gmail.com> writes:
Show 25 quoted lines
>>[Stalled]
>>
>>* tl/ls-tree-oid-only (2022-03-04) 12 commits
>> - ls-tree: support --object-only option for "git-ls-tree"
>> - ls-tree: introduce "--format" option
>> - cocci: allow padding with `strbuf_addf()`
>> - ls-tree: introduce struct "show_tree_data"
>> - ls-tree: slightly refactor `show_tree()`
>> - ls-tree: fix "--name-only" and "--long" combined use bug
>> - ls-tree: simplify nesting if/else logic in "show_tree()"
>> - ls-tree: rename "retval" to "recurse" in "show_tree()"
>> - ls-tree: use "size_t", not "int" for "struct strbuf"'s "len"
>> - ls-tree: use "enum object_type", not {blob,tree,commit}_type
>> - ls-tree: add missing braces to "else" arms
>> - ls-tree: remove commented-out code
>>
>> "git ls-tree" learns "--oid-only" option, similar to "--name-only",
>> and more generalized "--format" option.
>> source: <cover.1646390152.git.dyroneteng@gmail.com>
>
>
> Sorry for the late reply.
>
> I posted a updated patchset last week, we already had a private review on that,
> but maybe string need Ævar Arnfjörð Bjarmason for taking a look.I should at least take it out of the Stalled bin. An "all issues from previous reviews addressed and a final eyeballing tells us it looks good to go" would indeed be appreciated.
Thanks.