git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: ar/submodule-udpate (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7))

From
Glen Choo <chooglen@google.com>
Date
Mar 9, 2022, 22:09 UTC
Message-ID
<kl6l35jq6amh.fsf@chooglen-macbookpro.roam.corp.google.com>
In-Reply-To
<xmqq7d93kjsy.fsf@gitster.g>
Junio C Hamano <gitster@pobox.com> writes:
Show 34 quoted lines
>>> * ar/submodule-update (2022-03-04) 13 commits
>>>  - submodule--helper update-clone: check for --filter and --init
>>>  - submodule update: add tests for --filter
>>>  - submodule--helper: remove ensure-core-worktree
>>>  - submodule--helper update-clone: learn --init
>>>  - submodule--helper: allow setting superprefix for init_submodule()
>>>  - submodule--helper: refactor get_submodule_displaypath()
>>>  - submodule--helper run-update-procedure: learn --remote
>>>  - submodule--helper: don't use bitfield indirection for parse_options()
>>>  - submodule--helper: get remote names from any repository
>>>  - submodule--helper run-update-procedure: remove --suboid
>>>  - submodule--helper: reorganize code for sh to C conversion
>>>  - submodule--helper: remove update-module-mode
>>>  - submodule tests: test for init and update failure output
>>>
>>>  Rewrite of "git submodule update" in C (early part).
>>>
>>>  Will merge to 'next'?
>>>  source: <20220305001401.20888-1-chooglen@google.com>
>> A comment on the branch name: we kept the name 'ar/submodule-update'
>> from when Atharva Raykar <raykar.ath@gmail.com> prepared v1 of his
>> series that converts all of "git submodule update" to C. When other
>> authors sent subsequent versions, it still made sense to keep this name
>> because the patches still reached the same end state of having all of
>> "git submodule update" in C.
>>
>> However, I've since broken this series up in two (to play better with
>> other topics), and the above-named patches don't do a _full_ conversion
>> of "git submodule update". Is something like "ar/submodule-update-1"
>> more appropriate?
>
> You've already taken over the ownership of the majority of patches
> in the series, and it may not be a bad idea to rename it to
> something like gc/submodule-update-part-1 before it hits 'next'.

Sounds reasonable to me. That's similar to e.g. ab/config-based-hooks-[1|2], which used to be es/config-based-hooks.

> How many more parts do you anticipate to have, by the way?
Just one more (thankfully) :).
Previous: Junio C Hamano
Message 9 of 9 in “What's cooking in git.git (Mar 2022, #02; Mon, 7)”
  1. Junio C HamanoMar 8, 2022
  2. Teng LongMar 8, 2022
  3. Junio C HamanoMar 9, 2022
  4. ds/partial-bundles (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7))Derrick Stolee, Mar 8, 2022
  5. jc/stash-drop (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7))Phillip Wood, Mar 9, 2022
  6. Junio C HamanoMar 9, 2022
  7. ar/submodule-udpate (was Re: What's cooking in git.git (Mar 2022, #02; Mon, 7))Glen Choo, Mar 9, 2022
  8. Junio C HamanoMar 9, 2022
  9. Glen ChooMar 9, 2022

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.