Re: [PATCH v2 2/3] doc: interpret-trailers: don’t use deprecated config

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 3, 2023, 21:18 UTC
Message-ID: <xmqqbkk44qbo.fsf@gitster.g>
In-Reply-To: <ea06be8f5ac77e5be64ab674f5a4fbe0b7e56c0e.1680548650.git.code@khaugsbakk.name>

Kristoffer Haugsbakk <code@khaugsbakk.name> writes:

> [2]: “At the same time, in order to allow `git interpret-trailers` to
>    better simulate the behavior of `git command -s`,
>    'trailer.<token>.cmd' will not automatically execute.”

This may be a question more for Zhening than for you, but is the above a typo for "git commit -s", not "command"?

> +$ git config trailer.see.cmd "glog-ref"
> +$ cat msg.txt | git interpret-trailers --trailer=see

This is inherited from the original, but it is a poor practice to run "cat" on a single file and pipe the result to another command. Just redirect from the file into the downstream command instead, i.e.

    $ git interpret-trailers <empty-msg.txt

Perhaps we should do that as a preliminary clean-up before these updates?