git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v4 4/4] doc: interpret-trailers: fix example

From
Kristoffer Haugsbakk <code@khaugsbakk.name>
Date
May 1, 2023, 20:02 UTC
Message-ID
<95760aafe86315c67115e4152e9ea98737de8c9e.1682970213.git.code@khaugsbakk.name>
In-Reply-To
<cover.1682970213.git.code@khaugsbakk.name>

We need to provide `--trailer sign` since the command won’t output anything if you don’t give it an input and/or a `--trailer`. Furthermore, the message which already contains an s-o-b is wrong:

    $ git interpret-trailers --trailer sign <msg.txt
    Signed-off-by: Alice <alice@example.com>
    Signed-off-by: Alice <alice@example.com>
This can’t be what was originally intended.

So change the messages in this example to use the typical “subject/message” file.

Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name>
---
 Documentation/git-interpret-trailers.txt | 20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/Documentation/git-interpret-trailers.txt b/Documentation/git-interpret-trailers.txt
index acecc037ec..4b97f812be 100644
--- a/Documentation/git-interpret-trailers.txt
+++ b/Documentation/git-interpret-trailers.txt
@@ -322,16 +322,30 @@ $ git interpret-trailers --trailer 'Cc: Alice <alice@example.com>' --trailer 'Re
   'Signed-off-by: ' already, and show how it works:
 +
 ------------
+$ cat msg1.txt
+subject
+
+message
 $ git config trailer.sign.key "Signed-off-by: "
 $ git config trailer.sign.ifmissing add
 $ git config trailer.sign.ifexists doNothing
 $ git config trailer.sign.cmd 'echo "$(git config user.name) <$(git config user.email)>"'
-$ git interpret-trailers </dev/null
+$ git interpret-trailers --trailer sign <msg1.txt
+subject
+
+message
 
 Signed-off-by: Bob <bob@example.com>
-$ cat msg.txt
+$ cat msg2.txt
+subject
+
+message
+
 Signed-off-by: Alice <alice@example.com>
-$ git interpret-trailers <msg.txt
+$ git interpret-trailers --trailer sign <msg2.txt
+subject
+
+message
 
 Signed-off-by: Alice <alice@example.com>
 ------------
-- 
2.40.1
Previous: Kristoffer HaugsbakkNext: Junio C Hamano
Message 19 of 33 in “doc: interpret-trailers: remove trailing spaces”
  1. 1/3 doc: interpret-trailers: remove trailing spacesKristoffer Haugsbakk, Mar 31, 2023
  2. Kristoffer HaugsbakkMar 31, 2023
  3. Kristoffer HaugsbakkMar 31, 2023
  4. Junio C HamanoMar 31, 2023
  5. Junio C HamanoMar 31, 2023
  6. 0/3 doc: interpret-trailers: don't use deprecated configKristoffer Haugsbakk, Apr 3, 2023
  7. 0/4 doc: interpret-trailers: don't use deprecated configKristoffer Haugsbakk, Apr 12, 2023
  8. 1/4 doc: interpret-trailers: don’t use heredoc in examplesKristoffer Haugsbakk, Apr 12, 2023
  9. Junio C HamanoApr 12, 2023
  10. 2/4 doc: interpret-trailers: use input redirectionKristoffer Haugsbakk, Apr 12, 2023
  11. Junio C HamanoApr 12, 2023
  12. 3/4 doc: interpret-trailers: don’t use deprecated configKristoffer Haugsbakk, Apr 12, 2023
  13. 4/4 doc: interpret-trailers: fix exampleKristoffer Haugsbakk, Apr 12, 2023
  14. Junio C HamanoApr 12, 2023
  15. 0/4 doc: interpret-trailers: don't use deprecated configKristoffer Haugsbakk, May 1, 2023
  16. 1/4 doc: interpret-trailers: don’t use heredoc in examplesKristoffer Haugsbakk, May 1, 2023
  17. 2/4 doc: interpret-trailers: use input redirectionKristoffer Haugsbakk, May 1, 2023
  18. 3/4 doc: interpret-trailers: don’t use deprecated configKristoffer Haugsbakk, May 1, 2023
  19. 4/4 doc: interpret-trailers: fix exampleKristoffer Haugsbakk, May 1, 2023
  20. Junio C HamanoMay 1, 2023
  21. 2/3 doc: interpret-trailers: don’t use deprecated configKristoffer Haugsbakk, Mar 31, 2023
  22. Andrei RybakApr 1, 2023
  23. 3/3 doc: interpret-trailers: fix exampleKristoffer Haugsbakk, Mar 31, 2023
  24. 1/3 doc: interpret-trailers: don’t use heredoc in examplesKristoffer Haugsbakk, Apr 3, 2023
  25. Junio C HamanoApr 3, 2023
  26. 2/3 doc: interpret-trailers: don’t use deprecated configKristoffer Haugsbakk, Apr 3, 2023
  27. Junio C HamanoApr 3, 2023
  28. Kristoffer HaugsbakkApr 4, 2023
  29. Junio C HamanoApr 4, 2023
  30. ZheNing HuApr 5, 2023
  31. ZheNing HuApr 5, 2023
  32. Kristoffer HaugsbakkApr 5, 2023
  33. 3/3 doc: interpret-trailers: fix examplesKristoffer Haugsbakk, Apr 3, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.