Re: [PATCH 0/3] leak tests: mark remaining tests leak-free as such

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 24, 2023, 18:50 UTC
Message-ID: <xmqqbkewb7g4.fsf@gitster.g>
In-Reply-To: <cover.1692902414.git.me@ttaylorr.com>

Taylor Blau <me@ttaylorr.com> writes:

Show 10 quoted lines

> This series marks all leak-free tests as such, meaning that the above
> "make test" invocation will pass after this series. The bulk of the
> tests which are marked here in the first patch were always
> leak-free[^1]. The remaining two patches address a couple of special
> cases of tests which are also leak-free.
>
> Thanks in advance for your review!
>
> [^1]: At least as far back as v2.38.0, when the "check" mode of
>   GIT_TEST_PASSING_SANITIZE_LEAK was first introduced.

Nice to see "bugs" gone without any code changes ;-) It would have taken a lot of patience from your part, though, and your effort is very much appreciated.

Show 10 quoted lines

> Taylor Blau (3):
>   leak tests: mark a handful of tests as leak-free
>   leak tests: mark t3321-notes-stripspace.sh as leak-free
>   leak tests: mark t5583-push-branches.sh as leak-free
>
>  t/t3321-notes-stripspace.sh | 1 +
>  t/t5571-pre-push-hook.sh    | 1 +
>  t/t5583-push-branches.sh    | 1 +
>  t/t7516-commit-races.sh     | 2 ++
>  4 files changed, 5 insertions(+)