Re: [PATCH 0/3] leak tests: mark remaining tests leak-free as such
On Thu, Aug 24, 2023 at 04:50:10PM -0400, Jeff King wrote:
Show 16 quoted lines
> If I run a few by hand, I _do_ see leaks in them, but the exit codes are
> hidden from the test suite (they are sub-programs of scripts, etc). I
> guess you also have:
>
> GIT_TEST_SANITIZE_LEAK_LOG=true
>
> set, which should find those (and which you mention in your first
> commit). Turning that on eliminates some of them, but I'm left with:
>
> t5614 t5317 t5503
>
> not in your list. Which is super weird, because t5614 is marked with
> TEST_PASSES_SANITIZE_LEAK. Hrm. And if I run it again, I get a
> _different_ set (t5614 again, along with your 4, but also t5303, t7701,
> and t4050). I wonder if we have a race in the leak-log code or
> something (I'm running under prove with -j32, naturally).
Argh. It is this again:
https://lore.kernel.org/git/Yxl62zODF4oy1QL9@coredump.intra.peff.net/
Can we revisit that patch? Included again below for reference.
-- >8 --
Subject: [PATCH] test-lib: ignore uninteresting LSan output
When I run the tests in leak-checking mode the same way our CI job does, like:
make SANITIZE=leak \
GIT_TEST_PASSING_SANITIZE_LEAK=true \
GIT_TEST_SANITIZE_LEAK_LOG=true \
testthen LSan can racily produce useless entries in the log files that look like this:
==git==3034393==Unable to get registers from thread 3034307.
I think they're mostly harmless based on the source here:
https://github.com/llvm/llvm-project/blob/7e0a52e8e9ef6394bb62e0b56e17fa23e7262411/compiler-rt/lib/lsan/lsan_common.cpp#L414
which reads:
PtraceRegistersStatus have_registers =
suspended_threads.GetRegistersAndSP(i, ®isters, &sp);
if (have_registers != REGISTERS_AVAILABLE) {
Report("Unable to get registers from thread %llu.\n", os_id);
// If unable to get SP, consider the entire stack to be reachable unless
// GetRegistersAndSP failed with ESRCH.
if (have_registers == REGISTERS_UNAVAILABLE_FATAL)
continue;
sp = stack_begin;
}The program itself still runs fine and LSan doesn't cause us to abort. But test-lib.sh looks for any non-empty LSan logs and marks the test as a failure anyway, under the assumption that we simply missed the failing exit code somehow.
I don't think I've ever seen this happen in the CI job, but running locally using clang-14 on an 8-core machine, I can't seem to make it through a full run of the test suite without having at least one failure. And it's a different one every time (though they do seem to often be related to packing tests, which makes sense, since that is one of our biggest users of threaded code).
We can hack around this by only counting LSan log files that contain a line that doesn't match our known-uninteresting pattern.
Signed-off-by: Jeff King <peff@peff.net>
---
t/test-lib.sh | 1 +
1 file changed, 1 insertion(+)
Show changes to t/test-lib.sh +1 −0
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 293caf0f20..5ea5d1d62a 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -334,6 +334,7 @@ nr_san_dir_leaks_ () {
find "$TEST_RESULTS_SAN_DIR" \
-type f \
-name "$TEST_RESULTS_SAN_FILE_PFX.*" 2>/dev/null |
+ xargs grep -lv "Unable to get registers from thread" |
wc -l
}
--
2.42.0.448.g0caf9a9e14
Taylor Blau
