Re: [PATCH 4/7] sequencer: introduce functions to handle autostashes via refs
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 19, 2024, 20:09 UTC
- Message-ID
- <xmqqbk9hjdai.fsf@gitster.g>
- In-Reply-To
- <abcf1f5cf428072d19639dc4209e0c1554f3eb53.1705659748.git.ps@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 10 quoted lines
> We're about to convert the MERGE_AUTOSTASH ref to become non-special, > using the refs API instead of direct filesystem access to both read and > write the ref. The current interfaces to write autostashes is entirely > path-based though, so we need to extend them to also support writes via > the refs API instead. > > Ideally, we would be able to fully replace the old set of path-based > interfaces. But the sequencer will continue to write state into > "rebase-merge/autostash". This path is not considered to be a ref at all > and will thus stay is-is for now, which requires us to keep both path-
"is-is"???
Show 7 quoted lines
> and refs-based interfaces to handle autostashes. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > sequencer.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++---- > sequencer.h | 3 +++ > 2 files changed, 64 insertions(+), 5 deletions(-)
The conversion (rather, the introduction to allow refs API to be used to access them) look correct, but offhand I do not know what the implication of leaving the file based interface would be.
Thanks.