Re: [PATCH 1/7] sequencer: clean up pseudo refs with REF_NO_DEREF

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 22, 2024, 10:36 UTC
Message-ID: <Za5FEJOrUGTm620N@tanuki>
In-Reply-To: <xmqqttn9jfta.fsf@gitster.g>

On Fri, Jan 19, 2024 at 11:14:57AM -0800, Junio C Hamano wrote:

Show 13 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > When cleaning up the state-tracking pseudorefs CHERRY_PICK_HEAD or
> > REVERT_HEAD we do not set REF_NO_DEREF. In the unlikely case where those
> > refs are a symref we would thus end up deleting the symref targets, and
> > not the symrefs themselves.
> >
> > Harden the code to use REF_NO_DEREF to fix this.
> 
> This level of attention to detail is very much appreciated.  I
> suspect that this was inspired by the other topic we discussed the
> other day to tighten accesses to {MERGE,CHERRY_PICK,REVERT}_HEAD
> that is done via repo_get_oid() to the one based on read_ref_full()?

At least not directly, no. I was adding new calls to `delete_ref()` and was reflexively adding REF_NO_DEREF, which made me wonder why the other cases in the vicinity didn't use it yet. So it's more inspired by the first patch series that introduced the "special refs" classification, where I already added ref deletions with `REF_NO_DEREF`.

Patrick