git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] refs: fix duplicated word in comment

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 9, 2025, 16:22 UTC
Message-ID
<xmqqbjt5s3t5.fsf@gitster.g>
In-Reply-To
<CAN0heSoh4SuQcYHVVniO1BYH_C4O-BeF4kKxDg3uQPzpotLA1A@mail.gmail.com>
Martin Ågren <martin.agren@gmail.com> writes:
> Ok. In general, there's some trade-off to be made between "make a small change
> at the top of a twenty-line comment and rewrap the whole thing causing more
> churn than necessary and create more room for conflicts with other topics" and
> "make the change and live with slightly less beautiful wrapping".
Nice to see this choice spelled out.
Show 7 quoted lines
> In this
> particular case, the blast radius is small. `git show --word-diff` confirms
> that you simply removed the duplicate word and moved "common" (or "*").
>
> FWIW, this patch looks good to me.
>
> Martin

Thanks, both. Will queue.

Previous: Martin Ågren
Message 5 of 5 in “refs: fix duplicated word in comment”
  1. refs: fix duplicated word in commentChristian Fredrik Johnsen via GitGitGadget, Apr 4, 2025
  2. Martin ÅgrenApr 5, 2025
  3. refs: fix duplicated word in commentChristian Fredrik Johnsen via GitGitGadget, Apr 5, 2025
  4. Martin ÅgrenApr 7, 2025
  5. Junio C HamanoApr 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.