git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] refs: fix duplicated word in comment

From
MÅMartin Ågren <martin.agren@gmail.com>
Date
Apr 5, 2025, 10:01 UTC
Message-ID
<CAN0heSp9RhH=UMDqLs=Kd57RoseySrFT4sFeXrVV3h7f=daSaw@mail.gmail.com>
In-Reply-To
<pull.1940.git.git.1743791986754.gitgitgadget@gmail.com>
Hi Christian Fredrik,
Thanks for posting a patch.

On Fri, 4 Apr 2025 at 20:39, Christian Fredrik Johnsen via GitGitGadget <gitgitgadget@gmail.com> wrote:

Show 5 quoted lines
>
> From: Christian Fredrik Johnsen <christian@johnsen.no>
>
> Fix a typo in a comment in refs.c: "checking checking" → "checking".
> Signed-off-by: Christian Fredrik Johnsen <christian@johnsen.no>

There should be an empty line between the main part of the commit message and the Signed-off-by trailer.

Show 6 quoted lines
>                         /*
>                          * If we've already seen the directory we don't need to
> -                        * process it again. Skip it to avoid checking checking
> +                        * process it again. Skip it to avoid checking
>                          * common prefixes like "refs/heads/" repeatedly.
>                          */
Well-spotted. No doubt that this is the correct fix.
Martin
Previous: Christian Fredrik Johnsen via GitGitGadgetNext: Christian Fredrik Johnsen via GitGitGadget
Message 2 of 5 in “refs: fix duplicated word in comment”
  1. refs: fix duplicated word in commentChristian Fredrik Johnsen via GitGitGadget, Apr 4, 2025
  2. Martin ÅgrenApr 5, 2025
  3. refs: fix duplicated word in commentChristian Fredrik Johnsen via GitGitGadget, Apr 5, 2025
  4. Martin ÅgrenApr 7, 2025
  5. Junio C HamanoApr 9, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.