git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] xdiff-interface: stop using the_repository

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 9, 2026, 17:45 UTC
Message-ID
<xmqqbjhx6cb5.fsf@gitster.g>
In-Reply-To
<b05f81aa-6e8a-4e90-ac9e-85fb72784afb@web.de>
René Scharfe <l.s.r@web.de> writes:
Show 11 quoted lines
>>> -	ptr->ptr = odb_read_object(the_repository->objects, oid, &type, &size);
>>> +	ptr->ptr = odb_read_object(odb, oid, &type, &size);
>>>  	if (!ptr->ptr || type != OBJ_BLOB)
>>>  		die("unable to read blob object %s", oid_to_hex(oid));
>>>  	ptr->size = size;
>
> My initial version did that.  Then I realized that read_mmblob() is just
> a thin odb_read_object() wrapper that converts null_oid to
> empty_blob_oid and dies on non-blobs, though, so requiring a full repo
> pointer seemed excessive.  And all callers also use other odb_*
> functions already.

Absolutely. Passing the narrowest thing the callee needs is the right approach and that is what is done in the version posted.

Thanks. I presume that a small and final reroll is expected, if only to remove the now unnecessary #include, if not splitting it into three parts?

Previous: René ScharfeNext: René Scharfe
Message 6 of 14 in “xdiff-interface: stop using the_repository”
  1. xdiff-interface: stop using the_repositoryRené Scharfe, Feb 8, 2026
  2. Patrick SteinhardtFeb 9, 2026
  3. René ScharfeFeb 9, 2026
  4. Junio C HamanoFeb 9, 2026
  5. René ScharfeFeb 9, 2026
  6. Junio C HamanoFeb 9, 2026
  7. René ScharfeFeb 9, 2026
  8. Elijah NewrenFeb 9, 2026
  9. Junio C HamanoFeb 9, 2026
  10. René ScharfeFeb 15, 2026
  11. René ScharfeFeb 15, 2026
  12. xdiff-interface: stop using the_repositoryRené Scharfe, Feb 9, 2026
  13. Patrick SteinhardtFeb 10, 2026
  14. Junio C HamanoFeb 10, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.