Re: [PATCH] xdiff-interface: stop using the_repository

From: René Scharfe <l.s.r@web.de>
Date: Feb 9, 2026, 14:14 UTC
Message-ID: <ee549683-1c80-4a9b-83b4-a44fafb1a47f@web.de>
In-Reply-To: <aYmtab_uqMZBygAG@pks.im>

On 2/9/26 10:48 AM, Patrick Steinhardt wrote:

Show 16 quoted lines

> On Sun, Feb 08, 2026 at 02:47:40PM +0100, René Scharfe wrote:
>> diff --git a/xdiff-interface.c b/xdiff-interface.c
>> index 1a35556380..cd7493730b 100644
>> --- a/xdiff-interface.c
>> +++ b/xdiff-interface.c
>> @@ -7,6 +6,7 @@
>>  #include "config.h"
>>  #include "hex.h"
>>  #include "odb.h"
>> +#include "repository.h"
>>  #include "strbuf.h"
>>  #include "xdiff-interface.h"
>>  #include "xdiff/xtypes.h"
> 
> It's a bit surprising that we have to add this include, but I assume
> that we use a function that's declared in this file?

Good point, we don't actually need it. It's left over from an earlier version that had a struct repository pointer as new parameter. :-|

René