Re: [PATCH] Fix GNU/Hurd build

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 12, 2026, 20:38 UTC
Message-ID: <xmqqbjgsdbr6.fsf@gitster.g>
In-Reply-To: <20260312191901.174808-1-samuel.thibault@ens-lyon.org>

Samuel Thibault <samuel.thibault@ens-lyon.org> writes:

> GNU/Hurd does not have a PATH_MAX limitation

Thanks. clar folks might prefer to take it upstream and have us as a downstream to import from them, so I'll forward it first before taking it for ourselves.

It makes me wonder if an organization like this is easier to follow, i.e., platform specific settings first and then catch-all default at the end:

	#if defined(CLAR_LONGPATHS)
	#define CLAR_MAX_PATH 4096
	#elif defined(PATH_MAX)
	#define CLAR_MAX_PATH PATH_MAX
	#elif deifned(MAX_PATH)
	#define CLAR_MAX_PATH MAX_PATH
	#fi

	#if !defined(CLAR_MAX_PATH)
	#define CLAR_MAX_PATH 4096
	#fi

but that is a separate issue best handled by the clar folks.

--- >8 ---
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Thu, 12 Mar 2026 20:19:01 +0100
Subject: [PATCH] clar: compilation fix for GNU/Hurd

<clar.h> fails to define CLAR_MAX_PATH on GNU/Hurd where PATH_MAX is not defined.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
 t/unit-tests/clar/clar.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/unit-tests/clar/clar.h b/t/unit-tests/clar/clar.h
index ca72292ae9..4394aabbb9 100644
--- a/t/unit-tests/clar/clar.h
+++ b/t/unit-tests/clar/clar.h
@@ -10,7 +10,7 @@
 #include <stdlib.h>
 #include <limits.h>
 
-#if defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS)
+#if defined(__GNU__) || defined(_WIN32) && defined(CLAR_WIN32_LONGPATHS)
 # define CLAR_MAX_PATH 4096
 #elif defined(_WIN32)
 # define CLAR_MAX_PATH MAX_PATH

-- 
2.53.0-707-gf7b889d8f7