Re: [PATCH] Fix GNU/Hurd build

From: Patrick Steinhardt <ps@pks.im>
Date: Mar 13, 2026, 06:39 UTC
Message-ID: <abOxLFNGgZjo1dyi@pks.im>
In-Reply-To: <xmqqbjgsdbr6.fsf@gitster.g>

On Thu, Mar 12, 2026 at 01:38:21PM -0700, Junio C Hamano wrote:

Show 25 quoted lines

> Samuel Thibault <samuel.thibault@ens-lyon.org> writes:
> 
> > GNU/Hurd does not have a PATH_MAX limitation
> 
> Thanks.  clar folks might prefer to take it upstream and have us as
> a downstream to import from them, so I'll forward it first before
> taking it for ourselves.
> 
> It makes me wonder if an organization like this is easier to follow,
> i.e., platform specific settings first and then catch-all default at
> the end:
> 
> 	#if defined(CLAR_LONGPATHS)
> 	#define CLAR_MAX_PATH 4096
> 	#elif defined(PATH_MAX)
> 	#define CLAR_MAX_PATH PATH_MAX
> 	#elif deifned(MAX_PATH)
> 	#define CLAR_MAX_PATH MAX_PATH
> 	#fi
> 
> 	#if !defined(CLAR_MAX_PATH)
> 	#define CLAR_MAX_PATH 4096
> 	#fi
> 
> but that is a separate issue best handled by the clar folks.

Agreed, something like this would read better indeed. Samuel, do you want to maybe create a pull request in [1] to fix this in clar itself? You can then give me (@pks-gitlab) a ping and I'll be happy to review it. I can then handle the subsequent pull request for Git.

Thanks!

Patrick

[1]: https://github.com/clar-test/clar