Re: [RFC/PATCH] Fix path prefixing in grep_object

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2013, 03:35 UTC
Message-ID: <xmqqa9k6moif.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CABURp0qG7Nnjpp17MAO7Ltwf51EsswZ3GcT-qyt14Vs1tc9pGw@mail.gmail.com>

Phil Hord <phil.hord@gmail.com> writes:

Show 14 quoted lines

> On Sat, Aug 24, 2013 at 9:35 PM, Phil Hord <hordp@cisco.com> wrote:
>>
>> When the pathspec given to grep includes a tree name, the full
>> name of matched files is assembled using colon as a separator.
>> If the pathspec includes a tree name, it should use a slash
>> instead.
>>
>> Check if the pathspec already names a tree and ref (including
>> a colon) and use a slash if so.
>
> I think I used lots of wrong terminology there.  What do I call these
> things?
>
> HEAD:path is a tree.

It is one way to name a tree object, yes (another obvious way is to spell it out, e.g. 3610ac62).

> HEAD is a commit name.

It is one way to name the commit object, yes, but I am guessing that you are interested in these in the context of resolving HEAD:path. If that is the case, then "commit"-ness is not something you are interested in---any tree-ish would do (e.g. v1.8.4, maint^{tree}).

Show 7 quoted lines

> Maybe like this?
>
>   When a tree is given to grep, the full name of matched files
>   is assembled using colon as a separator.
>
>   If the tree name includes an object name, as in
>   HEAD:some/path, it should use a slash instead.

What problem are you trying to solve? It should use HEAD:some/path, not HEAD/some/path.