Re: [RFC/PATCH] Fix path prefixing in grep_object

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Aug 25, 2013, 04:23 UTC
Message-ID: <20130825042314.GE2882@elie.Belkin>
In-Reply-To: <xmqqa9k6moif.fsf@gitster.dls.corp.google.com>

Junio C Hamano wrote:

> Phil Hord <phil.hord@gmail.com> writes:
>> On Sat, Aug 24, 2013 at 9:35 PM, Phil Hord <hordp@cisco.com> wrote:

>>> When the pathspec given to grep includes a tree name, the full
>>> name of matched files is assembled using colon as a separator.
>>> If the pathspec includes a tree name, it should use a slash
>>> instead.

[...]

Show 5 quoted lines

>>   If the tree name includes an object name, as in
>>   HEAD:some/path, it should use a slash instead.
>
> What problem are you trying to solve?  It should use HEAD:some/path,
> not HEAD/some/path.

I think Phil meant that when "git grep" is asked to search within "HEAD:some/path", filenames tacked on at the end should be appended with a '/' separator instead of the usual ':' (e.g., "HEAD:some/path/inner/path.c", not "HEAD:some/path:inner/path.c"). Otherwise I cannot copy and paste "git grep" output and get something suitable for passing to "git show".

I don't think we have a standard name for the tree:path syntax. I've always just called it tree:path syntax. :)

Hope that helps, Jonathan