Re: [PATCH v5 2/3] upload-pack: prepare to extend allow-tip-sha1-in-want

From: Junio C Hamano <gitster@pobox.com>
Date: May 23, 2015, 00:53 UTC
Message-ID: <xmqqa8wwdshj.fsf@gitster.dls.corp.google.com>
In-Reply-To: <CABA5-zm4E71DV4hMw1Tifn-gqE4LzDDRzuo4vRL848bo_V5LLA@mail.gmail.com>

Fredrik Medley <fredrik.medley@gmail.com> writes:

Show 10 quoted lines

>>> +#define ALLOW_TIP_SHA1       01
>>> +static int allow_unadvertised_object_request;
>>
>> It is better to use "unsigned int" for these bit masks, as we are
>> not interested in the top-most bit getting special-cased by using a
>> signed type.  I'll amend this (and the one in upload-pack.c) while
>> applying, so no need to resend only to correct these two, unless you
>> have other reasons to reroll.
>
> Sounds like a good idea to change. Please amend it while applying.

Alright, will do.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.