git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 7/7] send-email: suppress leading and trailing whitespaces before alias expansion

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 10, 2015, 15:15 UTC
Message-ID
<xmqqa8w7oarl.fsf@gitster.dls.corp.google.com>
In-Reply-To
<1281238070.338321.1433928615479.JavaMail.zimbra@ensimag.grenoble-inp.fr>
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr> writes:
> I agree, I'd like to put it right after split_at_commas in a separate
> function "trim_list". Is it a good idea even if the function is one
> line long ?

Hmph, if I have "A, B, C" and call a function that gives an array of addresses, treating the input as comma-separated addresses, I would expect ("A", "B", "C") to be returned from that function, instead of having to later trim the whitespace around what is returned.

It suggests that split-at-commas _is_ a wrong abstraction, doesn't it? In other words, I think whitespace trimming is part of what the split-a-single-string-into-array-of-addresses helper function should be doing.

Previous: Remi LespinetNext: Matthieu Moy
Message 5 of 11 in “send-email: suppress leading and trailing whitespaces in addresses”
  1. 6/7 send-email: suppress leading and trailing whitespaces in addressesRemi Lespinet, Jun 9, 2015
  2. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 9, 2015
  3. Matthieu MoyJun 10, 2015
  4. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 10, 2015
  5. Junio C HamanoJun 10, 2015
  6. Matthieu MoyJun 10, 2015
  7. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 10, 2015
  8. Junio C HamanoJun 10, 2015
  9. Matthieu MoyJun 10, 2015
  10. Matthieu MoyJun 10, 2015
  11. 6/7 send-email: suppress leading and trailing whitespaces in addressesRemi Lespinet, Jun 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.