git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v3 7/7] send-email: suppress leading and trailing whitespaces before alias expansion

From
Remi Lespinet <remi.lespinet@ensimag.grenoble-inp.fr>
Date
Jun 10, 2015, 09:30 UTC
Message-ID
<1281238070.338321.1433928615479.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To
<vpqa8w89d5x.fsf@anie.imag.fr>
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Actually, once you have this, PATCH 6/7 becomes useless, right? (at
> least, the test passes if I revert it)
> It seems to me that doing this space trimming just once, inside or right
> after split_at_commas would be clearer.

You're right, I put it twice because of there's occurrences of sanitize_address which are not associated with expand_aliases, but it seems that it's all taken care of separately in different regexp. So there's no point to 6/7.

I agree, I'd like to put it right after split_at_commas in a separate function "trim_list". Is it a good idea even if the function is one line long ?

Previous: Matthieu MoyNext: Junio C Hamano
Message 4 of 11 in “send-email: suppress leading and trailing whitespaces in addresses”
  1. 6/7 send-email: suppress leading and trailing whitespaces in addressesRemi Lespinet, Jun 9, 2015
  2. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 9, 2015
  3. Matthieu MoyJun 10, 2015
  4. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 10, 2015
  5. Junio C HamanoJun 10, 2015
  6. Matthieu MoyJun 10, 2015
  7. 7/7 send-email: suppress leading and trailing whitespaces before alias expansionRemi Lespinet, Jun 10, 2015
  8. Junio C HamanoJun 10, 2015
  9. Matthieu MoyJun 10, 2015
  10. Matthieu MoyJun 10, 2015
  11. 6/7 send-email: suppress leading and trailing whitespaces in addressesRemi Lespinet, Jun 10, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.